Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker requirements #1679

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Docker requirements #1679

merged 1 commit into from
Jul 17, 2023

Conversation

criadoperez
Copy link
Contributor

Description

Updated docker requirements.

  • Docker Desktop is not required. Docker engine is.
  • The minimum version of docker engine is no longer 17.12.0+ but 20.10.0. This is because the docker-compose file is using the format 3.9 that was introduced with docker 20.10.0
  • Docker Compose requirement is version 1.29 not 2. Version 2 is no longer an independent binary and called with docker compose. With version 1.x of docker composer you call it with docker-compose. The scripts are currently using the older format of docker-compose.

@Stefan-Ethernal Stefan-Ethernal linked an issue Jun 29, 2023 that may be closed by this pull request
Docker compose v1 no longer available on releases after June 2023 #1680
Open
Stefan-Ethernal
Stefan-Ethernal approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you intended to adapt the cluster script to use docker compose instead of docker-compose through this or #1678 maybe?

Are any other changes needed?

@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 29, 2023 05:52
@criadoperez
Copy link
Contributor Author

No, PR #1678 doesn't touch that part, and keeps using docker-compose as it it now. I
The migration to Compose V2 should be a separate PR after #1678.

@Stefan-Ethernal Stefan-Ethernal removed a link to an issue Jun 29, 2023
Docker compose v1 no longer available on releases after June 2023 #1680
Open
@Stefan-Ethernal Stefan-Ethernal merged commit 04776a5 into 0xPolygon:develop Jul 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
@criadoperez criadoperez deleted the fix/docker branch July 17, 2023 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@criadoperez criadoperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@criadoperez @vcastellm @Stefan-Ethernal